linux-kernel - Re: [PATCH] [mempolicy] remove unnecessary is_valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADFvMYLm2BTqaf1rjSVxQ9TqYjhvkkdm+pe3HSwjY=MZWVz-aA@mail.gmail.com>
Date:	Mon, 17 Nov 2014 19:55:58 -0500
From:	Zhihui Zhang <zzhsuny@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Mel Gorman <mgorman@...e.de>, oleg@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [mempolicy] remove unnecessary is_valid_nodemask()

The filtering occurs in mpol_set_nodemask(), it reads like this:

                if (pol->flags & MPOL_F_RELATIVE_NODES)
                        mpol_relative_nodemask(&nsc->mask2, nodes,&nsc->mask1);
                else
                        nodes_and(nsc->mask2, *nodes, nsc->mask1);

so mask2 is based on mask1. mask2 is only used when nodes is not NULL
later. so we don't care the
case of (pol->mode == MPOL_PREFERRED && nodes_empty(*nodes)).

-Zhihui

On Mon, Nov 17, 2014 at 6:08 PM, Andrew Morton
<akpm@...ux-foundation.org> wrote:
> On Sat, 15 Nov 2014 21:49:57 -0500 Zhihui Zhang <zzhsuny@...il.com> wrote:
>
>> When nodes is true, nsc->mask2 has already been filtered by nsc->mask1, which has
>> already factored in node_states[N_MEMORY].
>>
>
> Please be more specific.  Where does that filtering occur?
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/