linux-kernel - Re: [PATCH] usbnet: rtl8150: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141118153042.GB18659@vm-taos-petkan.jnpr.net>
Date:	Tue, 18 Nov 2014 17:30:42 +0200
From:	Petko Manolov <petkan@...leusys.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	linux-usb@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usbnet: rtl8150: remove unused variable

On 14-11-18 18:29:59, Sudip Mukherjee wrote:
> we were just returning the initial value of res, instead now
> we are returning the value directly.

Looks OK, but could you please fix the wording of the commit message to something like:

	Remove unused variable.

This is a tiny patch and the code speaks for itself.


		Petko


> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> ---
>  drivers/net/usb/rtl8150.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
> index 6e87e57..d37b7dc 100644
> --- a/drivers/net/usb/rtl8150.c
> +++ b/drivers/net/usb/rtl8150.c
> @@ -753,14 +753,13 @@ static int rtl8150_open(struct net_device *netdev)
>  static int rtl8150_close(struct net_device *netdev)
>  {
>  	rtl8150_t *dev = netdev_priv(netdev);
> -	int res = 0;
>  
>  	netif_stop_queue(netdev);
>  	if (!test_bit(RTL8150_UNPLUG, &dev->flags))
>  		disable_net_traffic(dev);
>  	unlink_all_urbs(dev);
>  
> -	return res;
> +	return 0;
>  }
>  
>  static void rtl8150_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *info)
> -- 
> 1.8.1.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/