linux-kernel - Re: [PATCH 1/3] mfd: cros_ec: Add Chrome OS EC userspace device interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141118170001.6256c6df@lxorguk.ukuu.org.uk>
Date:	Tue, 18 Nov 2014 17:00:01 +0000
From:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
To:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
Cc:	Lee Jones <lee.jones@...aro.org>,
	Doug Anderson <dianders@...omium.org>,
	Bill Richardson <wfrichar@...omium.org>,
	Olof Johansson <olof@...om.net>, Simon Glass <sjg@...gle.com>,
	Gwendal Grignou <gwendal@...gle.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] mfd: cros_ec: Add Chrome OS EC userspace device
 interface

> +#ifdef CONFIG_COMPAT
> +struct compat_cros_ec_command {
> +	uint32_t version;
> +	uint32_t command;
> +	compat_uptr_t outdata;
> +	uint32_t outsize;
> +	compat_uptr_t indata;
> +	uint32_t insize;
> +	uint32_t result;
> +};
> +
> +struct compat_cros_ec_readmem {
> +	uint32_t offset;
> +	uint32_t bytes;
> +	compat_uptr_t buffer;
> +};
> 

This is a new API - arrange them to be 64bit safe and properly padded,
there is no excuse for needing compat crap except for legacy interfaces
you can't fix.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/