linux-kernel - Re: Implement lbr-as-callgraph v10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zjbnpv64.fsf@sejong.aot.lge.com>
Date:	Wed, 19 Nov 2014 15:21:39 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Andi Kleen <andi@...stfloor.org>, Jiri Olsa <jolsa@...nel.org>,
	linux-kernel@...r.kernel.org, "Liang\, Kan" <kan.liang@...el.com>
Subject: Re: Implement lbr-as-callgraph v10

Hi Jiri,

On Tue, 18 Nov 2014 12:00:07 +0100, Jiri Olsa wrote:
> On Tue, Nov 18, 2014 at 11:44:16AM +0100, Jiri Olsa wrote:
>> On Mon, Nov 17, 2014 at 06:34:57PM -0300, Arnaldo Carvalho de Melo wrote:
>> > Em Wed, Nov 12, 2014 at 06:05:18PM -0800, Andi Kleen escreveu:
>> > > [Reworks to address all the review feedback. Rebased to latest tree]
>> > > [Just a repost after a rebase]
>> > > [Even more review feedback and some bugs addressed.]
>> > > [Only port to changes in perf/core. No other changes.]
>> > > [Rebase to latest perf/core]
>> > > [Another rebase. No changes]
>> > > 
>> > > This patchkit implements lbr-as-callgraphs in per freport,
>> > > as an alternative way to present LBR information.
>> > 
>> > Ok, I have this in my perf/core branch, but I need to test it further,
>> > as I couldn't get the output that appears on some of the changelogs.
>> > 
>> > If you could take a look at
>> > 
>> > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux perf/core
>> > 
>> > To see if I made some mistake, that would be of help,
>> > 
>> 
>> I'm getting compile error for DEBUG=1
>
> looks like the BUILD_BUG_ON_MSG does not work correctly with -O6 we use

Nope, DEBUG=1 prevents -O6 from applied.  we have below in config/Makefile:

  ifndef DEBUG
    DEBUG := 0
  endif

  ifeq ($(DEBUG),0)
    CFLAGS += -O6
  endif


Looking at include/linux/bug.h, BUILD_BUG_ON is guarded under
__OPTIMIZE__ but BUILD_BUG_ON_MSG is not.  What about changing it to
BUILD_BUG_ON then?

Thanks,
Namhyung


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/