[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <546C70A1.9090707@rock-chips.com>
Date: Wed, 19 Nov 2014 18:27:45 +0800
From: Caesar Wang <caesar.wang@...k-chips.com>
To: Doug Anderson <dianders@...omium.org>
CC: Heiko Stübner <heiko@...ech.de>,
Kever Yang <kever.yang@...k-chips.com>,
Eddie Cai <cf@...k-chips.com>,
ZhenFu Fang <fzf@...k-chips.com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
Chris Zhong <chris.zhong@...k-chips.com>,
Sonny Rao <sonnyrao@...omium.org>
Subject: Re: [PATCH] ARM: dts: fix PWM clock found on RK3288 Socs
Doug,
在 2014/11/19 13:14, Doug Anderson 写道:
> Caesar,
>
> On Tue, Nov 18, 2014 at 7:25 PM, Caesar Wang <caesar.wang@...k-chips.com> wrote:
>> We use the new PWM IP on RK3288,but the PWM's clock indeed incorrect.
>>
>> Signed-off-by: Caesar Wang <caesar.wang@...k-chips.com>
>> ---
>> arch/arm/boot/dts/rk3288.dtsi | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
> Right, I reported this when Kever was doing his "unused clocks" patch.
> That's why this clock is currently "ignore unused".
>
> ...but though your change is right, I'd rather your change doesn't
> land quite yet. It totally wrecks havoc with the PWM regulator used
> on many rk3288 boards and will glitch the main "logic" voltage at
> bootup. I have some patches that are MASSIVELY WIP:
>
> https://chromium-review.googlesource.com/230640
> WIP: regulator: pwm: Tell regulator framework that we can't turn off
>
> https://chromium-review.googlesource.com/230641
> WIP: PWM: handle the fact that firmware might have left us enabled
>
> https://chromium-review.googlesource.com/230642
> WIP: pwm-regulator stuff
>
> I think that last one might blow up into several patches. We need to
> solve the problems from those patches before yours can really land.
>
>
> It's pretty high on my list to finish the above patches, but right now
> suspend/resume issues are higher priority so it's a bit stalled... If
> someone wants to hijack any of the above patches please let me know--I
> won't be offended.
OK,I see.
> -Doug
>
>
>
--
Best regards,
Caesar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists