linux-kernel - RE: [PATCH v4] ARM: EXYNOS: add Exynos3250 PMU support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <000a01d003eb$79fe9630$6dfbc290$@samsung.com>
Date:	Wed, 19 Nov 2014 16:54:10 +0530
From:	Pankaj Dubey <pankaj.dubey@...sung.com>
To:	'Bartlomiej Zolnierkiewicz' <b.zolnierkie@...sung.com>,
	'Kukjin Kim' <kgene.kim@...sung.com>
Cc:	'Chanwoo Choi' <cw00.choi@...sung.com>,
	'Kyungmin Park' <kyungmin.park@...sung.com>,
	'Tomasz Figa' <tomasz.figa@...il.com>,
	'Vikas Sajjan' <vikas.sajjan@...sung.com>,
	linux-samsung-soc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: RE: [PATCH v4] ARM: EXYNOS: add Exynos3250 PMU support

On Tuesday, November 18, 2014 11:05 PM, Bartlomiej Zolnierkiewicz Wrote:
> This patch prepares the PMU code for the future:
> - suspend/resume (S2R) support
> - cpuidle AFTR/W-AFTR modes support
> on Exynos3250.
> 
> Cc: Pankaj Dubey <pankaj.dubey@...sung.com>
> Cc: Vikas Sajjan <vikas.sajjan@...sung.com>
> Acked-by: Kyungmin Park <kyungmin.park@...sung.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>

Other than one small nitpick patch looks fine to me. Tested on Exynos3250
based
Espresso board and kernel booted fine.

Reviewed-by: Pankaj Dubey <pankaj.dubey@...sung.com>

> 
> +static void exynos3250_pmu_init(void)
> +{
> +	unsigned int value;
> +
> +	/*
> +	 * To prevent form issuing new bus request form L2 memory system

typo: %s/form/from

> +	 * If core status is power down, should be set '1' to L2 power down
> +	 */

Thanks,
Pankaj Dubey

> --
> 1.8.2.3


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/