linux-kernel - Re: [PATCH] tools: hv: ignore ENOBUFS in the KVP daemon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <871tozfe4t.fsf@vitty.brq.redhat.com>
Date:	Wed, 19 Nov 2014 15:39:46 +0100
From:	Vitaly Kuznetsov <vkuznets@...hat.com>
To:	Dexuan Cui <decui@...rosoft.com>
Cc:	"gregkh\@linuxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	"driverdev-devel\@linuxdriverproject.org" 
	<driverdev-devel@...uxdriverproject.org>,
	"olaf\@aepfle.de" <olaf@...fle.de>,
	"apw\@canonical.com" <apw@...onical.com>,
	"jasowang\@redhat.com" <jasowang@...hat.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>
Subject: Re: [PATCH] tools: hv: ignore ENOBUFS in the KVP daemon

Dexuan Cui <decui@...rosoft.com> writes:

>> -----Original Message-----
>> From: Vitaly Kuznetsov 
>> >> --
>> >>   Vitaly
>> >
>> > OK, I can add this new check:
>> > (I'll send out the v2 tomorrow in case  people have new comments)
>> >
>> 
>> Thanks!
>> 
>> > --- a/tools/hv/hv_kvp_daemon.c
>> > +++ b/tools/hv/hv_kvp_daemon.c
>> > @@ -1770,8 +1770,15 @@ kvp_done:
>> >
>> >                 len = netlink_send(fd, incoming_cn_msg);
>> >                 if (len < 0) {
>> > +                       int saved_errno = errno;
>> >                         syslog(LOG_ERR, "net_link send failed; error: %d %s", errno,
>> >                                         strerror(errno));
>> > +
>> > +                       if (saved_errno == ENOMEM || saved_errno ==  EAGAIN) {
>> 
>> Sorry for being pushy, but it seems ENOBUFS is also possible here (at
>> least man sendmsg mentions it).
> OK, I'll add this too. :-)
>
> BTW, I realized sendmsg() can't return EAGAIN here as that's for non-blocking
> socket.
>
> Here I simply ignore the error, hoping the other end will re-try.
>

I agree, it's sufficient to ignore ENOBUFS on recieve path and both
ENOMEM/ENOBUFS on send.

Thanks!

>> 
>> > +                               syslog(LOG_ERR, "send error: ignored");
>> > +                               continue;
>> > +                       }
>> > +
>> >                         exit(EXIT_FAILURE);
>> >                 }
>> >         }
>> >
>> > Thanks,
>> > -- Dexuan
>> 
>>   Vitaly
>
> -- Dexuan

-- 
  Vitaly
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/