linux-kernel - Re: [alsa-devel][PATCH] ASoC: wm8960: Add shared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141119175132.GF12443@opensource.wolfsonmicro.com>
Date:	Wed, 19 Nov 2014 17:51:32 +0000
From:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:	Zidan Wang <b50113@...escale.com>
Cc:	broonie@...nel.org, lgirdwood@...il.com, perex@...ex.cz,
	tiwai@...e.de, lars@...afoo.de, Li.Xiubo@...escale.com,
	patches@...nsource.wolfsonmicro.com, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel][PATCH] ASoC: wm8960: Add shared_lrclk and capless
	to device tree

On Wed, Nov 19, 2014 at 08:36:08PM +0800, Zidan Wang wrote:
> wm8960 codec has a wm8960_data struct which has two fields shared_lrclk and capless.
> The wm8960_data is get from platform_data and it is reasonable to set it from device
> tree when platform_data is null.
> And when shared_lrclk is set, LRCM will be enabled. But the following software reset
> in wm8960_probe will reset it to the default state. So LRCM operation should after
> software reset.
> 
> Signed-off-by: Zidan Wang <b50113@...escale.com>
> ---
>  sound/soc/codecs/wm8960.c | 49 ++++++++++++++++++++++++++++++-----------------
>  1 file changed, 31 insertions(+), 18 deletions(-)
> 
> diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c
> index 4dc4e85..1d56c90 100644
> --- a/sound/soc/codecs/wm8960.c
> +++ b/sound/soc/codecs/wm8960.c
> @@ -1038,6 +1055,7 @@ static int wm8960_i2c_probe(struct i2c_client *i2c,
>  
>  	wm8960 = devm_kzalloc(&i2c->dev, sizeof(struct wm8960_priv),
>  			      GFP_KERNEL);
> +
>  	if (wm8960 == NULL)
>  		return -ENOMEM;

Extra blank line accidentally being added here.

Also I would probably make the shifting of the shared_lrclk
handling a different patch as that is a bug fix and shouldn't
really be tided into a patch adding DT bindings.

As pointed out this will need a corresponding DT documentaion
patch, but apart from those things looks good to me.

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/