| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <9023565.IShqyyQhGs@tachyon.chronox.de> Date: Wed, 19 Nov 2014 03:36:45 +0100 From: Stephan Mueller <smueller@...onox.de> To: Herbert Xu <herbert@...dor.apana.org.au> Cc: Daniel Borkmann <dborkman@...hat.com>, quentin.gouchet@...il.com, LKML <linux-kernel@...r.kernel.org>, linux-crypto@...r.kernel.org, ABI/API <linux-api@...r.kernel.org> Subject: Re: [PATCH v2 06/10] crypto: AF_ALG: make setkey optional Am Dienstag, 18. November 2014, 22:10:13 schrieb Herbert Xu: Hi Herbert, > On Sun, Nov 16, 2014 at 03:26:58AM +0100, Stephan Mueller wrote: > > The current AF_ALG implementation requires that a userspace interface > > implementation must provide a callback for setkey. Such a call is not > > appliable to random number generators. > > > > To prepare AF_ALG for the addition of a random number generator user > > space interface, this function callback invocation is made optional. > > > > Signed-off-by: Stephan Mueller <smueller@...onox.de> > > Did you actually try this? AFAICS setkey is already optional. You are correct. I tested the kernel without my patch and the setkey on the RNG handle is rejected. I now also see the check already present in the alg_setkey function. This patch will be removed from a new patchset. > > Cheers, -- Ciao Stephan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists