linux-kernel - Re: [PATCH] serial: fix io address assign method with Fintek PCI-to-UART Product

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141119034518.GB15293@kroah.com>
Date:	Tue, 18 Nov 2014 19:45:18 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Peter Hung <hpeter@...il.com>
Cc:	jslaby@...e.cz, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Peter Hung <hpeter+linux_kernel@...il.com>
Subject: Re: [PATCH] serial: fix io address assign method with Fintek
 PCI-to-UART Product

On Wed, Nov 19, 2014 at 10:35:53AM +0800, Peter Hung wrote:
> The original driver fixed the io address with 0xe000+idx*8, but real io address assigned from BIOS
> is dynamically from read PCI configure space 0x24, 0x20, 0x1c.
> 
> The Fintek F81504/F81508/F81512 maybe malfunction without this patch and malfunction surely when
> more the 1 PCI card.

Please wrap these lines at 72 columns please, like git wants you to.

> 
> Signed-off-by: Peter Hung <hpeter+linux_kernel@...il.com>
> ---
>  drivers/tty/serial/8250/8250_pci.c | 63 ++++++++++++++++++++++++++++----------
>  1 file changed, 47 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
> index 0468e15..6dfa227 100644
> --- a/drivers/tty/serial/8250/8250_pci.c
> +++ b/drivers/tty/serial/8250/8250_pci.c
> @@ -1551,28 +1551,51 @@ static int pci_fintek_setup(struct serial_private *priv,
>  {
>  	struct pci_dev *pdev = priv->dev;
>  	unsigned long base;
> -	unsigned long iobase;
> +	unsigned long iobase = 0;

Why initialize this to 0?  That shouldn't be needed as you set it later
in the function before you use it, right?

Care to try again?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/