linux-kernel - Re: [git pull] Input updates for 3.18-rc4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141119210552.GA5464@lantern>
Date:	Wed, 19 Nov 2014 22:05:52 +0100
From:	ulrik.debie-os@...ig.org
To:	Marcus Overhagen <marcus.overhagen@...il.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Benjamin Tissoires <benjamin.tissoires@...il.com>,
	Hans de Goede <hdegoede@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-input <linux-input@...r.kernel.org>,
	Jiri Kosina <jkosina@...e.cz>
Subject: Re: [git pull] Input updates for 3.18-rc4

Hi,

Thanks Dmitry, the fix you provided will mitigate the regression. But
there might be more that is going on for v4 hardware. The detection
of PACKET_TRACKPOINT can be made more strict.
Thank you Marcus and Benjamin for the reports.

Sorry for the regression, it was not expected that lowest nibble of packet[3]
is 0x6 for non-trackpoint packets.

So we have two laptops where 
1) according to the msb of the capabilities has no trackpoint
Benjamin, can you give feedback if the laptop has actually a trackpoint/stick/
how else one calls that strange but convenient thing in the middle of the 
keyboard ?
Marcus, do you even have a trackpoint ?

2) mouse packets are received on serio that smell like a trackpoint packet.
When I look at the packet dump from marcus,
It would also fail the sanity check when crc_enabled is off, but probably
succeeds on marcus laptop ? 

Marcus, can you send the firmware and capabilities information for your laptop
(it is available in the kernel messages). Could you send me a kernel message log for a period of 1 minute when using the touchpad with the debug set to 2 ?

I wonder packet[3]==0x46, why the 0x40 and 0x04 bits are set and the current
elantech driver does not do anything with that part of the information. The
packets from Marcus are probably v4 'MOTION' packets, and since the odd 
behaviour when they are ignored, they at least are containing the motion
information, but maybe some extra information is hidden. There are multiple
of those packets in a very short timeframe (milliseconds), I wonder if all
of the MOTION packets have this signature. 

At least now I'm happy that the warning is there, because otherwise it 
might be more difficult to pinpoint the cause.

Thanks,
Ulrik

On Wed, Nov 19, 2014 at 08:23:32PM +0100, Marcus Overhagen wrote:
> Date: Wed, 19 Nov 2014 20:23:32 +0100
> From: Marcus Overhagen <marcus.overhagen@...il.com>
> To: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: Benjamin Tissoires <benjamin.tissoires@...il.com>, Ulrik De Bie
>  <ulrik.debie-os@...ig.org>, Hans de Goede <hdegoede@...hat.com>,
>  "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, linux-input
>  <linux-input@...r.kernel.org>, Jiri Kosina <jkosina@...e.cz>
> Subject: Re: [git pull] Input updates for 3.18-rc4
> 
> Hi Dmitry,
> 
> luckily I found some time right now. I haven't reverted the original large
> patch, but I tested your short patch and it fixes the problem for me.
> 
> regards
> Marcus
> 
> On Wed, Nov 19, 2014 at 7:39 PM, Dmitry Torokhov
> <dmitry.torokhov@...il.com> wrote:
> > On Wed, Nov 19, 2014 at 07:20:21PM +0100, Marcus Overhagen wrote:
> >> Hi,
> >>
> >> I will try reverting that, but may need until tomorrow or Friday.
> >>
> >> Just now I made a warm reboot from rc3 to rc5 and initially scrolling
> >> behaviour was ok,  but after about a minute it went wrong and I got
> >> this:
> >>
> >> [  179.705362] ------------[ cut here ]------------
> >> [  179.705382] WARNING: CPU: 3 PID: 0 at
> >> drivers/input/mouse/elantech.c:433
> >> elantech_report_trackpoint.isra.5+0x199/0x1b0 [psmouse]()
> >> [  179.705385] psmouse serio1: elantech: Unexpected trackpoint message
> >
> > Or just this for now:
> >
> > diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
> > index 3fcb6b3..294f613 100644
> > --- a/drivers/input/mouse/elantech.c
> > +++ b/drivers/input/mouse/elantech.c
> > @@ -793,7 +793,7 @@ static int elantech_packet_check_v4(struct psmouse *psmouse)
> >         unsigned char packet_type = packet[3] & 0x03;
> >         bool sanity_check;
> >
> > -       if ((packet[3] & 0x0f) == 0x06)
> > +       if ((packet[3] & 0x0f) == 0x06 && etd->tp_dev)
> >                 return PACKET_TRACKPOINT;
> >
> >         /*
> >
> > --
> > Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/