linux-kernel - RE: [RFC PATCH v4] ACPICA/Events: Add support to ensure GPE is disabled by default for handlers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1AE640813FDE7649BE1B193DEA596E88026A3E81@SHSMSX101.ccr.corp.intel.com>
Date:	Thu, 20 Nov 2014 06:47:16 +0000
From:	"Zheng, Lv" <lv.zheng@...el.com>
To:	"Kirill A. Shutemov" <kirill@...temov.name>
CC:	Lv Zheng <zetalog@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
	"Brown, Len" <len.brown@...el.com>
Subject: RE: [RFC PATCH v4] ACPICA/Events: Add support to ensure GPE is
 disabled by default for handlers.

Hi, Kirill

Could also help to confirm if this patch can also fix the issue.
Please help to validate the 2 fix patchsets separately.

Thanks in advance.

Best regards
-Lv

> From: Zheng, Lv
> Sent: Thursday, November 20, 2014 2:45 PM
> 
> On some platforms, GPE is not disabled by default after ACPI hardware is
> enabled. This confuses GPE drivers. This patch adds support to disable GPE
> by default for GPE handler drivers.
> 
> Signed-off-by: Lv Zheng <lv.zheng@...el.com>
> Cc: Kirill A. Shutemov <kirill@...temov.name>
> ---
>  drivers/acpi/acpica/evxface.c |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> Index: linux-acpica/drivers/acpi/acpica/evxface.c
> ===================================================================
> --- linux-acpica.orig/drivers/acpi/acpica/evxface.c
> +++ linux-acpica/drivers/acpi/acpica/evxface.c
> @@ -821,6 +821,14 @@ acpi_install_gpe_handler(acpi_handle gpe
>  	    ~(ACPI_GPE_XRUPT_TYPE_MASK | ACPI_GPE_DISPATCH_MASK);
>  	gpe_event_info->flags |= (u8)(type | ACPI_GPE_DISPATCH_HANDLER);
> 
> +	/*
> +	 * Make sure that the GPE is disabled by default for the GPE
> +	 * handler driver. It is expected that the GPE handler driver
> +	 * should invoke acpi_enable_gpe() after installing the GPE
> +	 * handler.
> +	 */
> +	(void)acpi_hw_low_set_gpe(gpe_event_info, ACPI_GPE_DISABLE);
> +
>  	acpi_os_release_lock(acpi_gbl_gpe_lock, flags);
> 
>  unlock_and_exit:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/