lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 20 Nov 2014 09:56:34 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Zidan Wang <b50113@...escale.com>, broonie@...nel.org
CC:	lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.de,
	ckeepax@...nsource.wolfsonmicro.com, Li.Xiubo@...escale.com,
	patches@...nsource.wolfsonmicro.com, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel][PATCH v2 1/2] ASoC: wm8960: Add device tree support

On 11/20/2014 09:41 AM, Zidan Wang wrote:
[...][
> +Optional properties:
> +  - shared_lrclk: This is a boolean property. If present, the LRCM bit of
> +	R24 (Additional control 2 ) gets set, indicating that ADCLRC and DACLRC
> +	will be disabled only when ADC (Left and Right) and DAC (Left and Right)
> +	are disabled.
> +
> +  - capless: This is a boolean property. If present, OUT3 will be enabled
> +	and disabled together with HP_L and HP_R in response to jack detect events.


Custom properties need a vendor prefix and properties should use '-' instead 
of '_'. Also the devicetree describes the hardware and not the driver, so 
the description should say for which hardware setups this flag should be 
set, not what the behavior of the driver will be.

- Lars

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists