linux-kernel - Re: [PATCH v2] tools: hv: ignore ENOBUFS and ENOMEM in the KVP daemon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87fvdedxgb.fsf@vitty.brq.redhat.com>
Date:	Thu, 20 Nov 2014 10:37:40 +0100
From:	Vitaly Kuznetsov <vkuznets@...hat.com>
To:	Dexuan Cui <decui@...rosoft.com>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	driverdev-devel@...uxdriverproject.org, olaf@...fle.de,
	apw@...onical.com, jasowang@...hat.com, kys@...rosoft.com,
	haiyangz@...rosoft.com
Subject: Re: [PATCH v2] tools: hv: ignore ENOBUFS and ENOMEM in the KVP daemon

Dexuan Cui <decui@...rosoft.com> writes:

> Under high memory pressure and very high KVP R/W test pressure, the netlink
> recvfrom() may transiently return ENOBUFS to the daemon -- we found this
> during a 2-week stress test.
>
> We'd better not terminate the daemon on the failure, because a typical KVP
> user will re-try the R/W and hopefully it will succeed next time.
>
> We can also ignore the errors on sending.
>
> Cc: Vitaly Kuznetsov <vkuznets@...hat.com>
> Cc: K. Y. Srinivasan <kys@...rosoft.com>
> Signed-off-by: Dexuan Cui <decui@...rosoft.com>
> ---
>
> v2: I also ignore the errors on sending, as Vitaly suggested.

Thanks,

Reviewed-by: Vitaly Kuznetsov <vkuznets@...hat.com>

>
>  tools/hv/hv_kvp_daemon.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
> index 22b0764..6a6432a 100644
> --- a/tools/hv/hv_kvp_daemon.c
> +++ b/tools/hv/hv_kvp_daemon.c
> @@ -1559,8 +1559,15 @@ int main(int argc, char *argv[])
>  				addr_p, &addr_l);
>
>  		if (len < 0) {
> +			int saved_errno = errno;
>  			syslog(LOG_ERR, "recvfrom failed; pid:%u error:%d %s",
>  					addr.nl_pid, errno, strerror(errno));
> +
> +			if (saved_errno == ENOBUFS) {
> +				syslog(LOG_ERR, "receive error: ignored");
> +				continue;
> +			}
> +
>  			close(fd);
>  			return -1;
>  		}
> @@ -1763,8 +1770,15 @@ kvp_done:
>
>  		len = netlink_send(fd, incoming_cn_msg);
>  		if (len < 0) {
> +			int saved_errno = errno;
>  			syslog(LOG_ERR, "net_link send failed; error: %d %s", errno,
>  					strerror(errno));
> +
> +			if (saved_errno == ENOMEM || saved_errno == ENOBUFS) {
> +				syslog(LOG_ERR, "send error: ignored");
> +				continue;
> +			}
> +
>  			exit(EXIT_FAILURE);
>  		}
>  	}

-- 
  Vitaly
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/