lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 20 Nov 2014 10:39:32 +0000 From: Stefano Stabellini <stefano.stabellini@...citrix.com> To: Russell King - ARM Linux <linux@....linux.org.uk> CC: Stefano Stabellini <stefano.stabellini@...citrix.com>, <xen-devel@...ts.xensource.com>, <konrad.wilk@...cle.com>, Ian Campbell <Ian.Campbell@...rix.com>, <david.vrabel@...rix.com>, <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, <catalin.marinas@....com> Subject: Re: [PATCH v9 05/13] arm: introduce is_device_dma_coherent On Thu, 20 Nov 2014, Russell King - ARM Linux wrote: > On Tue, Nov 18, 2014 at 04:49:21PM +0000, Stefano Stabellini wrote: > > ping? > > Sending something which wants my attention _To:_ me is always a good idea :) I'll keep that in mind :-) > The patch is fine in itself, but I have a niggle about the > is_device_dma_coherent() - provided this is only used in architecture > specific code, that should be fine. It could probably do with a comment > to that effect in an attempt to discourage drivers using it (thereby > becoming less portable to other architectures.) Can I take this as an Acked-by? Good point regarding the comment. Maybe I can add: /* do not use this function in a driver */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists