linux-kernel - Re: [PATCH 3/3] mfd: cros_ec: Expose Chrome OS Lightbar to users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141120132733.GE13269@x1>
Date:	Thu, 20 Nov 2014 13:27:33 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
Cc:	Doug Anderson <dianders@...omium.org>,
	Bill Richardson <wfrichar@...omium.org>,
	Olof Johansson <olof@...om.net>, Simon Glass <sjg@...gle.com>,
	Gwendal Grignou <gwendal@...gle.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] mfd: cros_ec: Expose Chrome OS Lightbar to users

On Thu, 20 Nov 2014, Javier Martinez Canillas wrote:

> Hello Lee,
> 
> On 11/18/2014 03:22 PM, Lee Jones wrote:
> >> ---
> >>  drivers/mfd/Makefile           |   2 +-
> >>  drivers/mfd/cros_ec_dev.c      |   2 +
> >>  drivers/mfd/cros_ec_dev.h      |   3 +
> >>  drivers/mfd/cros_ec_lightbar.c | 347 +++++++++++++++++++++++++++++++++++++++++
> > 
> > By the sounds of the description, it doesn't seem as though this
> > driver lives in MFD.  I suggest another home, such as drivers/led.
> > 
> 
> You are right. As I said in the other email, I'll move it to
> drivers/platform/chrome/ which seems like a more suitable place.

Does it?  I would have thought 'lightbar' lives in LEDs, but I guess
that's between you and the drivers/platform/chrome maintainer now.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/