linux-kernel - i40e/i40e_ethtool.c weirdness?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <51793.1416511307@turing-police.cc.vt.edu>
Date:	Thu, 20 Nov 2014 14:21:47 -0500
From:	Valdis Kletnieks <Valdis.Kletnieks@...edu>
To:	Mitch Williams <mitch.a.williams@...el.com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	Catherine Sullivan <catherine.sullivan@...el.com>,
	Shannon Nelson <shannon.nelson@...el.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: i40e/i40e_ethtool.c weirdness?

(spotted while looking at a 'git bisect visualize' for something else)

After this commit:

Author: Mitch Williams <mitch.a.williams@...el.com>  2014-09-13 03:40:47
Committer: Jeff Kirsher <jeffrey.t.kirsher@...el.com>  2014-10-23 23:38:04

    i40e: Add 10GBaseT support

    Add driver support for 10GBaseT device.

we have the following chunk of code in i40e_ethtool.c:

        case I40E_PHY_TYPE_10GBASE_SFPP_CU:
                ecmd->supported = SUPPORTED_10000baseT_Full;
                break;
        case I40E_PHY_TYPE_1000BASE_KX:
        case I40E_PHY_TYPE_1000BASE_T:
                ecmd->supported = SUPPORTED_Autoneg |
                                  SUPPORTED_10000baseT_Full |
                                  SUPPORTED_1000baseT_Full |
                                  SUPPORTED_100baseT_Full;
                ecmd->advertising = ADVERTISED_Autoneg |
                                    ADVERTISED_10000baseT_Full |
                                    ADVERTISED_1000baseT_Full |
                                    ADVERTISED_100baseT_Full;
                break;
        case I40E_PHY_TYPE_100BASE_TX:
                ecmd->supported = SUPPORTED_Autoneg |
                                  SUPPORTED_10000baseT_Full |
                                  SUPPORTED_1000baseT_Full |
                                  SUPPORTED_100baseT_Full;
                ecmd->advertising = ADVERTISED_Autoneg |
                                    ADVERTISED_10000baseT_Full |
                                    ADVERTISED_1000baseT_Full |
                                    ADVERTISED_100baseT_Full;
                break;
        case I40E_PHY_TYPE_SGMII:
                ecmd->supported = SUPPORTED_Autoneg |

I'm confused by the fact that 2 cases that by name are 100M and 1G parts
got bits saying that 10G is "supported" - was that intentional?


Content of type "application/pgp-signature" skipped