linux-kernel - Re: [RESEND PATCH] usb: gadget: at91_udc: move prepare clk into process context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141120195049.GF23217@saruman>
Date:	Thu, 20 Nov 2014 13:50:49 -0600
From:	Felipe Balbi <balbi@...com>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
CC:	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>,
	Boris BREZILLON <boris.brezillon@...e-electrons.com>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	<linux-usb@...r.kernel.org>, <ronald.wahl@...itan.com>,
	Felipe Balbi <balbi@...com>, <stable@...r.kernel.org>
Subject: Re: [RESEND PATCH] usb: gadget: at91_udc: move prepare clk into
 process context

On Wed, Nov 19, 2014 at 04:37:27PM +0100, Nicolas Ferre wrote:
> From: Ronald Wahl <ronald.wahl@...itan.com>
> 
> Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b (usb: gadget: at91_udc:
> prepare clk before calling enable) added clock preparation in interrupt
> context. This is not allowed as it might sleep. Also setting the clock
> rate is unsafe to call from there for the same reason. Move clock
> preparation and setting clock rate into process context (at91udc_probe).
> 
> Signed-off-by: Ronald Wahl <ronald.wahl@...itan.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
> Acked-by: Boris Brezillon <boris.brezillon@...e-electrons.com>
> Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>
> Cc: Felipe Balbi <balbi@...com>
> Cc: <stable@...r.kernel.org> # v3.17+
> ---
> Hi Felipe,
> 
> I forgot to answer you on this patch. So I resend it now with the proper
> "stable" tag. You can also queue it during this -rc phase if you feel it is
> still possible.

I think it's late for v3.18, so it'll go on v3.19 and get backported to
3.17 and 3.18. Sorry :-s

cheers

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)