linux-kernel - Re: [PATCH] mm/zsmalloc: avoid duplicate assignment of prev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADAEsF9foZzneOY+0b_S71b8xVhrX+bNqGZCcgaL56c_SNicOQ@mail.gmail.com>
Date:	Fri, 21 Nov 2014 13:25:37 +0800
From:	Ganesh Mahendran <opensource.ganesh@...il.com>
To:	Minchan Kim <minchan@...nel.org>
Cc:	Nitin Gupta <ngupta@...are.org>, iamjoonsoo.kim@....com,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/zsmalloc: avoid duplicate assignment of prev_class

Hello

2014-11-21 11:43 GMT+08:00 Minchan Kim <minchan@...nel.org>:
> On Thu, Nov 20, 2014 at 09:08:33PM +0800, Mahendran Ganesh wrote:
>> In zs_create_pool(), prev_class is assigned (ZS_SIZE_CLASSES - 1)
>> times. And the prev_class only references to the previous alloc
>> size_class. So we do not need unnecessary assignement.
>>
>> This patch modifies *prev_class* to *prev_alloc_class*. And the
>> *prev_alloc_class* will only be assigned when a new size_class
>> structure is allocated.
>>
>> Signed-off-by: Mahendran Ganesh <opensource.ganesh@...il.com>
>> ---
>>  mm/zsmalloc.c |    9 +++++----
>>  1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
>> index b3b57ef..ac2b396 100644
>> --- a/mm/zsmalloc.c
>> +++ b/mm/zsmalloc.c
>> @@ -970,7 +970,7 @@ struct zs_pool *zs_create_pool(gfp_t flags)
>>               int size;
>>               int pages_per_zspage;
>>               struct size_class *class;
>> -             struct size_class *prev_class;
>> +             struct size_class *uninitialized_var(prev_alloc_class);
>
> https://lkml.org/lkml/2012/10/27/71
> In addition, I prefer prev_class.

Thanks for you review. I will resend the patch.

>
> Thanks.
>
> --
> Kind regards,
> Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/