linux-kernel - RE: [PATCH 2/2] cpufreq: qoriq: rename the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dedc11e3150d44ee89bb1e96b5447687@DM2PR03MB574.namprd03.prod.outlook.com>
Date:	Fri, 21 Nov 2014 09:16:23 +0000
From:	Yuantian Tang <Yuantian.Tang@...escale.com>
To:	Viresh Kumar <viresh.kumar@...aro.org>
CC:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linuxppc-dev@...abs.org" <linuxppc-dev@...abs.org>,
	"Jason.Jin@...escale.com" <Jason.Jin@...escale.com>
Subject: RE: [PATCH 2/2] cpufreq: qoriq: rename the driver

Hello Viresh,

When I use -C -M options, checkpatch reports error:

[tangyt@...an linux-pm]$ ./scripts/checkpatch.pl 0002-cpufreq-qoriq-rename-the-driver.patch 
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
 drivers/cpufreq/{ppc-corenet-cpufreq.c => qoriq-cpufreq.c} | 0

ERROR: Does not appear to be a unified-diff format patch

total: 1 errors, 1 warnings, 0 lines checked

0002-cpufreq-qoriq-rename-the-driver.patch has style problems, please review.

I just rename it and do not change anyting. Isn't that allowed?

Thanks,
Yuantian

> -----Original Message-----
> From: Viresh Kumar [mailto:viresh.kumar@...aro.org]
> Sent: Friday, November 21, 2014 3:56 PM
> To: Tang Yuantian-B29983
> Cc: Rafael J. Wysocki; Linux Kernel Mailing List; linux-pm@...r.kernel.org;
> linuxppc-dev@...abs.org; Jin Zhengxiong-R64188
> Subject: Re: [PATCH 2/2] cpufreq: qoriq: rename the driver
> 
> On 21 November 2014 12:58, Tang Yuantian <Yuantian.Tang@...escale.com>
> wrote:
> > This driver works on all QorIQ platforms which include ARM-based cores
> > and PPC-based cores.
> > Rename it in order to represent better.
> >
> > Signed-off-by: Tang Yuantian <Yuantian.Tang@...escale.com>
> > ---
> >  drivers/cpufreq/ppc-corenet-cpufreq.c | 371 ----------------------------------
> >  drivers/cpufreq/qoriq-cpufreq.c       | 371
> ++++++++++++++++++++++++++++++++++
> >  2 files changed, 371 insertions(+), 371 deletions(-)  delete mode
> > 100644 drivers/cpufreq/ppc-corenet-cpufreq.c
> >  create mode 100644 drivers/cpufreq/qoriq-cpufreq.c
> 
> This is not reviewable at all.. How do I verify that you haven't changed something
> in the files as well ?
> 
> To make life easy always create patches with:
> 
> git format-patch -C -M
> 
> Above options handle renames pretty well.