linux-kernel - Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABgxDoLy-+a7TAm7VWo5pYF7xZv4SM9=Zjcd1V6khnRqZbsFAw@mail.gmail.com>
Date:	Fri, 21 Nov 2014 14:18:21 +0100
From:	Romain Perier <romain.perier@...il.com>
To:	Johan Hovold <johan@...nel.org>
Cc:	Lee Jones <lee.jones@...aro.org>, Mark Brown <broonie@...nel.org>,
	Heiko Stübner <heiko@...ech.de>,
	Grant Likely <grant.likely@...aro.org>, robh <robh@...nel.org>,
	devicetree <devicetree@...r.kernel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Rutland <mark.rutland@....com>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>, Felipe Balbi <balbi@...com>
Subject: Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"

2014-11-21 11:59 GMT+01:00 Johan Hovold <johan@...nel.org>:
> On Thu, Nov 13, 2014 at 01:34:58PM +0000, Auto Configured wrote:
>> From: Romain Perier <romain.perier@...il.com>
>>
>> It reverts commit a4b4e0461ec5 ("of: Add standard property for poweroff capability").
>> As discussed on the mailing list, it makes more sense to rename back to the
>> old established property name, without the vendor prefix. Problem being that
>> the word "source" usually tends to be used for inputs and that is out of control
>> of the OS. The poweroff capability is an output which simply turns the
>> system-power off. Also, this property might be used by drivers which power-off
>> the system and power back on subsequent RTC alarms. This seems to suggest to
>> remove "poweroff" from the property name and to choose "system-power-controller"
>> as the more generic name. This patchs adds the required renaming changes and
>> defines an helper function which is compatible with both properties, the old one
>> which was only used by tps65910 and the new one without vendor-prefix.
>
> Now this is a bit of a mess.
>
> There's a commit in the mfd tree, 25f833c1171d ("mfd: tps65910: Convert
> ti,system-power-controller DT property to poweroff-source"), which
> breaks all dts using tps65910 since these are never updated to the now
> retracted property name ("poweroff-source").

No seriously ? yes, this is why I ask for feedbacks since 3 weeks... ^^

>
> This one should simply be reverted ASAP.
>
>> Signed-off-by: Romain Perier <romain.perier@...il.com>
>> ---
>>  .../bindings/power/{poweroff.txt => power-controller.txt}        | 0
>>  .../devicetree/bindings/regulator/act8865-regulator.txt          | 4 ++--
>>  drivers/mfd/tps65910.c                                           | 9 ++++++++-
>>  drivers/regulator/act8865-regulator.c                            | 2 +-
>>  include/linux/of.h                                               | 6 +++---
>>  5 files changed, 14 insertions(+), 7 deletions(-)
>
> Romain, what tree is this patch against? The changes to the tps65910
> driver appears not to even be in the regulator tree, yet you asked Mark
> to merge this. And the MFD maintainer is not even on CC.


I work with linux-next, this patch is present in that tree. If I
remember correctly, it was merged by Lee Jones (so it was merged onto
the mfd tree)

>
> Let's fix the breakage by reverting the offending commit in mfd. Then the
> new standard name can be introduced in regulator alone (e.g. this patch
> without the tps65910 bits) as nothing outside of regulator should be
> using the new power-off feature (or binding) for act8865. Then other
> drivers and dts can be converted to use the new property name (while
> retaining backwards compatibility) for 3.20.
>
> [ We should probably also consider adding an "of_device_is_" prefix to
> the helper name for consistency. ]
>
> Johan

Maintainers, Mark, Grant, Lee, what do you think ?

Thanks,
Romain
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/