linux-kernel - Re: [PATCH] media: pci: smipcie: Fix dependency for DVB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141121161316.23963dc5@recife.lan>
Date:	Fri, 21 Nov 2014 16:13:16 -0200
From:	Mauro Carvalho Chehab <mchehab@....samsung.com>
To:	Andreas Ruprecht <rupran@...server.de>
Cc:	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-next@...r.kernel.org, sfr@...b.auug.org.au
Subject: Re: [PATCH] media: pci: smipcie: Fix dependency for DVB_SMIPCIE

Em Fri, 21 Nov 2014 18:51:59 +0100
Andreas Ruprecht <rupran@...server.de> escreveu:

> In smipcie.c, the function i2c_bit_add_bus() is called. This
> function is defined by the I2C bit-banging interfaces enabled
> with CONFIG_I2C_ALGOBIT.
> 
> As there was no dependency in Kconfig, CONFIG_I2C_ALGOBIT could
> be set to "m" while CONFIG_DVB_SMIPCIE was set to "y", resulting
> in a build error due to an undefined reference. This patch adds
> the dependency on CONFIG_I2C_ALGOBIT in Kconfig.
> 
> Signed-off-by: Andreas Ruprecht <rupran@...server.de>
> Reported-by: Jim Davis <jim.epost@...il.com>
> ---
>  drivers/media/pci/smipcie/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/pci/smipcie/Kconfig b/drivers/media/pci/smipcie/Kconfig
> index 75a2992..c728721 100644
> --- a/drivers/media/pci/smipcie/Kconfig
> +++ b/drivers/media/pci/smipcie/Kconfig
> @@ -1,6 +1,6 @@
>  config DVB_SMIPCIE
>  	tristate "SMI PCIe DVBSky cards"
> -	depends on DVB_CORE && PCI && I2C
> +	depends on DVB_CORE && PCI && I2C && I2C_ALGOBIT

IMHO, the best would be, instead, to select I2C_ALGOBIT.

>  	select DVB_M88DS3103 if MEDIA_SUBDRV_AUTOSELECT
>  	select MEDIA_TUNER_M88TS2022 if MEDIA_SUBDRV_AUTOSELECT
>  	select MEDIA_TUNER_M88RS6000T if MEDIA_SUBDRV_AUTOSELECT
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/