linux-kernel - Re: [PATCHv7 1/8] usb: dwc2: Update the gadget driver to use common dwc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <546E9E8F.2050909@foxmail.com>
Date:	Fri, 21 Nov 2014 10:08:15 +0800
From:	Roy <yunzhi.li@...mail.com>
To:	dinguyen@...nsource.altera.com, paulz@...opsys.com, balbi@...com
CC:	dinh.linux@...il.com, swarren@...dotorg.org,
	b.zolnierkie@...sung.com, matthijs@...in.nl, r.baldyga@...sung.com,
	jg1.han@...sung.com, sachin.kamat@...aro.org, ben-linux@...ff.org,
	dianders@...omium.org, kever.yang@...k-chips.com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Kever Yang <kever.yang@...k-chips.com>, roy.li@...k-chiips.com,
	jwerner@...omium.org, huangtao@...k-chips.com,
	dianders@...omium.org
Subject: Re: [PATCHv7 1/8] usb: dwc2: Update the gadget driver to use common
 dwc2_hsotg structure

Hi Dinh:

On 2014/11/12 1:13, dinguyen@...nsource.altera.com wrote:
> From: Dinh Nguyen <dinguyen@...nsource.altera.com>
>
> Adds the gadget data structure and appropriate data structure pointers
> to the common dwc2_hsotg data structure. To keep the driver data
> dereference code looking clean, the gadget variable declares are only available
> for peripheral and dual-role mode. This is needed so that the dwc2_hsotg data
> structure can be used by the hcd and gadget drivers.
>
> Updates gadget.c to use the dwc2_hsotg data structure and gadget pointers
> that have been moved into the common dwc2_hsotg structure.
>
> Signed-off-by: Dinh Nguyen <dinguyen@...nsource.altera.com>
> Signed-off-by: Paul Zimmerman <paulz@...opsys.com>
> ---
> v7: Addressed comments from Felipe Balbi on which variables should not be just
>     limited to gadget(phy, uphy, regulator_bulk_data_supplies, irq, clk,
>     debug_root, debug_file, and debug_fifo).
I hope your dual-roal patches could bring the intializtion code of
hsotg->clk and hsotg->phy out from dwc2_gadget_init() into
dwc2_driver_probe() like intializtion of irq and regs base address.
Because the host-only platforms may also need clk gating when enter
suspend for power saving.
> v6: None
> v5: Keep the changes to mininum and maintain hcd and gadget driver to build
>     and work separately. Use IS_ENABLED() instead of #if defined
> v3: Updated with paulz's suggestion to avoid double pointers.
> v2: Left the function parameter name as 'hsotg' and just changed its type.
>

-- 
--------
Roy Li @ Rockchip

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/