linux-kernel - Re: [PATCH] ASoC: rockchip: i2s: Add dependency to I2S device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141121185856.GJ3815@sirena.org.uk>
Date:	Fri, 21 Nov 2014 18:58:56 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Andreas Ruprecht <rupran@...server.de>
Cc:	Heiko Stuebner <heiko@...ech.de>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: rockchip: i2s: Add dependency to I2S device driver

On Fri, Nov 21, 2014 at 07:35:13PM +0100, Andreas Ruprecht wrote:
> Currently, CONFIG_SND_SOC_ROCKCHIP_I2S could also be selected
> without having CONFIG_SND_SOC_ROCKCHIP enabled.
> 
> As this makes no sense (and breaks the build, when the option
> CONFIG_SND_SOC_GENERIC_DMAENGINE_PCM - which would be selected by
> CONFIG_SND_SOC_ROCKCHIP - is not enabled), a Kconfig dependency
> is added to CONFIG_SND_SOC_ROCKCHIP_I2S. This will make the item
> visible only if CONFIG_SND_SOC_ROCKCHIP is enabled.

This doesn't seem like an obvious fix - why is the fix not to put the
select on the I2S driver (which is the thing that actually depends on
the dmaengine stuff)?  

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)