linux-kernel - Re: [PATCH v13 5/9] arm: omap1: Migrate debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141121233958.GB7046@atomide.com>
Date:	Fri, 21 Nov 2014 15:39:59 -0800
From:	Tony Lindgren <tony@...mide.com>
To:	Daniel Thompson <daniel.thompson@...aro.org>
Cc:	Russell King <linux@....linux.org.uk>,
	Arnd Bergmann <arnd@...db.de>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	spear-devel@...t.st.com, Paul Bolle <pebolle@...cali.nl>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	John Stultz <john.stultz@...aro.org>,
	Sumit Semwal <sumit.semwal@...aro.org>, patches@...aro.org,
	linaro-kernel@...ts.linaro.org,
	Arnd Bergmann <arnd.bergmann@...aro.org>,
	linux-omap@...r.kernel.org
Subject: Re: [PATCH v13 5/9] arm: omap1: Migrate debug_ll macros to use 8250.S

* Daniel Thompson <daniel.thompson@...aro.org> [141117 06:53]:
> The omap1's debug-macro.S is similar to the generic 8250 code. Compared to
> the 8520 code the omap1 macro automatically determines what UART to use
> based on breadcrumbs left by the bootloader and automatically copes with
> the eccentric register layout on OMAP7XX.
> 
> This patch drops both these features and relies instead on the generic
> 8250 macros:
> 
> 1. Dropping support for the bootloader breadcrumbs is identical to the
>    way the migration was handled for OMAP2 (see 808b7e07464d...).
> 
> 2. Support for OMAP7XX still exists but it must be configured by hand
>    (DEBUG_OMAP7XXUART1/2/3) rather than handled at runtime.
> 
> Signed-off-by: Daniel Thompson <daniel.thompson@...aro.org>
> Cc: Russell King <linux@....linux.org.uk>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: Tony Lindgren <tony@...mide.com>
> Cc: Arnd Bergmann <arnd.bergmann@...aro.org>
> Cc: linux-omap@...r.kernel.org
> Tested-by: Aaro Koskinen <aaro.koskinen@....fi>

Looks OK to me, probably best that these are queued all together so:

Acked-by: Tony Lindgren <tony@...mide.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/