linux-kernel - Re: [PATCH 1/1 linux-next] iio: common: remove unnecessary sizeof(u8)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54707C6E.4060807@kernel.org>
Date:	Sat, 22 Nov 2014 12:07:10 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Hartmut Knaack <knaack.h@....de>,
	Fabian Frederick <fabf@...net.be>, linux-kernel@...r.kernel.org
CC:	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>, linux-iio@...r.kernel.org
Subject: Re: [PATCH 1/1 linux-next] iio: common: remove unnecessary sizeof(u8)

On 22/11/14 01:26, Hartmut Knaack wrote:
> Fabian Frederick schrieb am 16.11.2014 13:33:
>> sizeof(u8) is always 1.
>>
>> Signed-off-by: Fabian Frederick <fabf@...net.be>
> Acked-by: Hartmut Knaack <knaack.h@....de>
Applied to the togreg branch of iio.git - initially pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan
>> ---
>>  drivers/iio/common/st_sensors/st_sensors_spi.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/common/st_sensors/st_sensors_spi.c b/drivers/iio/common/st_sensors/st_sensors_spi.c
>> index 78a6a1a..5b37737 100644
>> --- a/drivers/iio/common/st_sensors/st_sensors_spi.c
>> +++ b/drivers/iio/common/st_sensors/st_sensors_spi.c
>> @@ -54,7 +54,7 @@ static int st_sensors_spi_read(struct st_sensor_transfer_buffer *tb,
>>  	if (err)
>>  		goto acc_spi_read_error;
>>  
>> -	memcpy(data, tb->rx_buf, len*sizeof(u8));
>> +	memcpy(data, tb->rx_buf, len);
>>  	mutex_unlock(&tb->buf_lock);
>>  	return len;
>>  
>>
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/