| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 22 Nov 2014 12:18:45 -0800 From: Jeremiah Mahler <jmmahler@...il.com> To: Oliver Hartkopp <socketcan@...tkopp.net> Cc: linux-can@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] can: eliminate banner[] variable and switch to pr_info() Oliver, On Sat, Nov 22, 2014 at 05:41:28PM +0100, Oliver Hartkopp wrote: > On 22.11.2014 08:42, Jeremiah Mahler wrote: > >Several CAN modules use a design pattern with a banner[] variable at the > >top which defines a string that is used once during init to print the > >banner. The string is also embedded with KERN_INFO which makes it > >printk() specific. > > > >Improve the code by eliminating the banner[] variable and moving the > >string to where it is printed. Then switch from printk(KERN_INFO to > >pr_info() for the lines that were changed. > > > >Signed-off-by: Jeremiah Mahler <jmmahler@...il.com> > > Acked-by: Oliver Hartkopp <socketcan@...tkopp.net> > > Next time please only post on linux-can ML which is the first address for > CAN related stuff - as long as you don't feel it's a networking relevant > issue. > > But for almost editorial changes - which is not urgent - linux-can should be > enough. > > Thanks, > Oliver > Will do, thanks. -- - Jeremiah Mahler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists