linux-kernel - crypto: user - crypto_alg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <3095384.PkgHxCg8eG@tauon>
Date:	Sat, 22 Nov 2014 23:25:05 +0100
From:	Stephan Mueller <smueller@...onox.de>
To:	Herbert Xu <herbert@...dor.apana.org.au>,
	steffen.klassert@...unet.com
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: crypto: user - crypto_alg_match removal

Hi Steffen, Herbert,

may I ask for the reasons why crypto_alg_match exists? Doesn't it 
implement crypto_alg_lookup -- and that not even complete? Is there a 
particular reason why this exact flag of crypto_alg_match is really 
needed in the context of crypto_user?

Unless there is such valid reason, may I ask whether we can remove 
crypto_alg_match and simply use crypto_alg_lookup in all instances where 
crypto_alg_match is invoked using the following replacement:

alg = crypto_alg_lookup(p->cru_name, p->cru_type, p->cru_mask)

The only problem with this replacement is that p->cru_driver_name is not 
considered with that. Do you think a double invocation of 
crypto_alg_lookup should be done or that even the user space interface 
should be changed such that cru_driver_name is removed from it?

Note, this change would now imply that crypto_user follows the kernel-
internal crypto API invocation approach.

Thanks
Stephan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/