linux-kernel - Re: [PATCH] drivers:staging:skein:skein

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 22 Nov 2014 14:01:06 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Anjana Sasindran <anjanasasindran123@...il.com>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH] drivers:staging:skein:skein_generic.c: Fixed a
 whitespace error

On Sat, Nov 22, 2014 at 01:11:59PM +0530, Anjana Sasindran wrote:
>      This patch fixes the checkpatch.pl error:
> 
it still does not apply to next-20141121
>      ERROR: trailing whitespace

and i am not seeing any trailing whitespace at line 191 of this file.
if you base your patch on next-20141121 your patch should have been:

diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
index 60d16b6..8660509 100644
--- a/drivers/staging/skein/skein_generic.c
+++ b/drivers/staging/skein/skein_generic.c
@@ -191,7 +191,6 @@ static int __init skein_generic_init(void)

	 return 0;

-               
 unreg512:
	 crypto_unregister_shash(&alg512);
 unreg256:


thanks
sudip

> 
> Signed-off-by: Anjana Sasindran <anjanasasindran123@...il.com>
> ---
>  drivers/staging/skein/skein_generic.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
> index 7096d5a..268e4de 100644
> --- a/drivers/staging/skein/skein_generic.c
> +++ b/drivers/staging/skein/skein_generic.c
> @@ -188,7 +188,6 @@ static int __init skein_generic_init(void)
>  		goto unreg256;
>  	if (crypto_register_shash(&alg1024))
>  		goto unreg512;
> -
>  	return 0;
>  unreg512:
>  	crypto_unregister_shash(&alg512);
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/