lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 23 Nov 2014 22:58:34 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Lekshmi <andnlnbn18@...il.com>
Cc:	gregkh@...uxfoundation.org, matt@...ezulu.com,
	raghav3276@...il.com, josh@...htriplett.org,
	tapaswenipathak@...il.com, vitaly.osipov@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Drivers:staging:wlan-ng: Fixed line over 80 characters
 warning

On Sun, Nov 23, 2014 at 03:26:54PM +0530, Lekshmi wrote:
> The following chaeckpatch warning was fixed:
> WARNING: line over 80 characters
> 
> Signed-off-by: Lekshmi <andnlnbn18@...il.com>
> ---
>  drivers/staging/wlan-ng/prism2fw.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c
> index e907380..5c3fd2d 100644
> --- a/drivers/staging/wlan-ng/prism2fw.c
> +++ b/drivers/staging/wlan-ng/prism2fw.c
> @@ -238,7 +238,8 @@ static int prism2_fwtry(struct usb_device *udev, wlandevice_t *wlandev)
>  *	0	- success
>  *	~0	- failure
>  ----------------------------------------------------------------*/
> -static int prism2_fwapply(const struct ihex_binrec *rfptr, wlandevice_t *wlandev)
> +static int prism2_fwapply(const struct ihex_binrec *rfptr,
> +			  wlandevice_t *wlandev)
>  {
>  	signed int result = 0;
>  	struct p80211msg_dot11req_mibget getmsg;
> @@ -707,7 +708,8 @@ static int plugimage(struct imgchunk *fchunk, unsigned int nfchunks,
>  			continue;
>  		}
>  
> -		/* Validate plug address against chunk data and identify chunk */
> +		/* Validate plug address against chunk data
> +		 * and identify chunk */
this is not the style for multiline comment. please check the CodingStyle in Documentation.

thanks
sudip

>  		for (c = 0; c < nfchunks; c++) {
>  			cstart = fchunk[c].addr;
>  			cend = fchunk[c].addr + fchunk[c].len;
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ