linux-kernel - Re: [PATCH v2 1/2] mfd: da9063: Get irq base dynamically before registering device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141124100743.GB4241@x1>
Date:	Mon, 24 Nov 2014 10:07:43 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Dmitry Lavnikevich <d.lavnikevich@...-solutions.com>
Cc:	support.opensource@...semi.com, sameo@...ux.intel.com,
	lgirdwood@...il.com, broonie@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] mfd: da9063: Get irq base dynamically before
 registering device

On Fri, 21 Nov 2014, Dmitry Lavnikevich wrote:

> After registering mfd device with proper irq_base
> platform_get_irq_byname() calls will return VIRQ instead of local IRQ.
> This fixes da9063 rtc registration issue:
> da9063-rtc da9063-rtc: Failed to request ALARM IRQ 1: -22
> 
> Signed-off-by: Dmitry Lavnikevich <d.lavnikevich@...-solutions.com>
> ---
>  drivers/mfd/da9063-core.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/da9063-core.c b/drivers/mfd/da9063-core.c
> index 93db8bb..f38bc98 100644
> --- a/drivers/mfd/da9063-core.c
> +++ b/drivers/mfd/da9063-core.c
> @@ -118,7 +118,7 @@ int da9063_device_init(struct da9063 *da9063, unsigned int irq)
>  		da9063->irq_base = pdata->irq_base;
>  	} else {
>  		da9063->flags = 0;
> -		da9063->irq_base = 0;
> +		da9063->irq_base = -1;
>  	}
>  	da9063->chip_irq = irq;
>  
> @@ -168,6 +168,8 @@ int da9063_device_init(struct da9063 *da9063, unsigned int irq)
>  		return ret;
>  	}
>  
> +	da9063->irq_base = regmap_irq_chip_get_base(da9063->regmap_irq);
> +
>  	ret = mfd_add_devices(da9063->dev, -1, da9063_devs,
>  			      ARRAY_SIZE(da9063_devs), NULL, da9063->irq_base,
>  			      NULL);

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/