linux-kernel - Re: Another Obsolete Fix me in trace.h?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54730B33.1080101@siemens.com>
Date:	Mon, 24 Nov 2014 11:40:51 +0100
From:	Jan Kiszka <jan.kiszka@...mens.com>
To:	Paolo Bonzini <pbonzini@...hat.com>, nick <xerofoify@...il.com>,
	gleb@...nel.org, Steven Rostedt <rostedt@...dmis.org>
CC:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org, kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Another Obsolete Fix me in trace.h?

On 2014-11-24 11:12, Paolo Bonzini wrote:
> On 24/11/2014 05:36, nick wrote:
>> Greetings Again Gleb and others,
>> I am assuming in the code I am pasting below the fix me is obsolete now and I can remove it. :)
>> Cheers Nick
>> TP_printk("%s (0x%x)",
>>                   __print_symbolic(__entry->exception, kvm_trace_sym_exc),
>>                    /* FIXME: don't print error_code if not present */
>>                   __entry->has_error ? __entry->error_code : 0)
>> );
>>
> 
> No, it's not obsolete, the idea is to print only
> 
>    %s
> 
> instead of
> 
>    %s (0x%x)
> 
> if __entry->has_error is false.  I don't know the trace API well enough
> to know if that is possible.

Last time I ran across such a scenario, it was not feasible and
essentially required separate tracepoints. But maybe Steven knows a trick.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/