lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 24 Nov 2014 13:44:58 +0300 From: Alexey Khoroshilov <khoroshilov@...ras.ru> To: Wei Liu <wei.liu2@...rix.com> CC: Ian Campbell <ian.campbell@...rix.com>, xen-devel@...ts.xenproject.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org Subject: Re: [PATCH] xen-netback: do not report success if xenvif_alloc() fails On 24.11.2014 13:00, Wei Liu wrote: > On Sat, Nov 22, 2014 at 01:56:28AM +0300, Alexey Khoroshilov wrote: >> If xenvif_alloc() failes, netback_probe() reports success as well as >> "online" uevent is emitted. It does not make any sense, but it just > Sorry, I don't follow. KOBJ_ONLINE event is not emitted in the event of > xenvif_alloc fails, is it? Yes, you are right. > >> misleads users. >> >> The patch implements propagation of error code if xenvif creation fails. >> > This patch not only implements propagation of error code when xenvif > creation fails, but also when xenbus_scanf fails. You can simply write > "This patch implements propagation of error code for > backend_create_xenvif". > > The rest of this patch looks good to me. Can you rewrite commit message > and resubmit, thanks. Ok. -- Thank you, Alexey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists