linux-kernel - Re: [PATCH] [media] omap24xx/tcm825x: remove pointless Makefile entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5473119D.6080205@cisco.com>
Date:	Mon, 24 Nov 2014 12:08:13 +0100
From:	Hans Verkuil <hansverk@...co.com>
To:	Paul Bolle <pebolle@...cali.nl>,
	Hans Verkuil <hans.verkuil@...co.com>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	Valentin Rothberg <valentinrothberg@...il.com>,
	Sakari Ailus <sakari.ailus@....fi>,
	linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [media] omap24xx/tcm825x: remove pointless Makefile entry

I found the same thing and it is already part of my pull request
to Mauro.

I'm setting this patch as Obsoleted in patchwork.

It's unclear what happened. My original patch definitely removed both
Makefile lines.

Regards,

	Hans

On 11/24/14 11:53, Paul Bolle wrote:
> The deprecated omap2 camera drivers were recently removed. Both the
> Kconfig symbol VIDEO_TCM825X and the drivers/staging/media/omap24xx
> directory are gone. So the Makefile entry that references both is now
> pointless. Remove it too.
> 
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> ---
> Tested by grepping the tree.
> 
> Triggered by commit db85a0403be4 ("[media] omap24xx/tcm825x: remove
> deprecated omap2 camera drivers."), which is included in next-20141124.
> What happened is that it removed only one of the two Makefile entries
> for omap24xx.
> 
>  drivers/staging/media/Makefile | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/media/Makefile b/drivers/staging/media/Makefile
> index 97bfef97f838..30fb352fc4a9 100644
> --- a/drivers/staging/media/Makefile
> +++ b/drivers/staging/media/Makefile
> @@ -4,7 +4,6 @@ obj-$(CONFIG_LIRC_STAGING)	+= lirc/
>  obj-$(CONFIG_VIDEO_DT3155)	+= dt3155v4l/
>  obj-$(CONFIG_VIDEO_DM365_VPFE)	+= davinci_vpfe/
>  obj-$(CONFIG_VIDEO_OMAP4)	+= omap4iss/
> -obj-$(CONFIG_VIDEO_TCM825X)     += omap24xx/
>  obj-$(CONFIG_DVB_MN88472)       += mn88472/
>  obj-$(CONFIG_DVB_MN88473)       += mn88473/
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/