linux-kernel - [PATCH] [media] omap: Fix typo "HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 24 Nov 2014 13:07:45 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	Mauro Carvalho Chehab <mchehab@....samsung.com>
Cc:	Valentin Rothberg <valentinrothberg@...il.com>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] [media] omap: Fix typo "HAS_MMU"

Commit 38a073116525 ("[media] omap: be sure that MMU is there for
COMPILE_TEST") added a dependency on HAS_MMU. There's no Kconfig symbol
HAS_MMU. Use MMU instead.

Signed-off-by: Paul Bolle <pebolle@...cali.nl>
---
0) Perhaps it would have been better to add a line or two explaining why
MMU is now a separate dependency, as Mauro suggested.

Commit 38a073116525 tells us that "COMPILE_TEST fail[s] on (some) archs
without MMU". It doesn't tell on which architectures nor how it fails.
And I was unable to figure that out myself so I decided to stay silent
on that aspect of this patch.

1) A Fixes: line seems not worth the trouble here.

2) Tested on top of next-20141124 by doing, in short:
    cp arch/x86/configs/x86_64_defconfig .config
    echo CONFIG_COMPILE_TEST=y >> .config
    echo CONFIG_MEDIA_SUPPORT=y >> .config
    echo CONFIG_MEDIA_CAMERA_SUPPORT=y >> .config
    echo CONFIG_V4L_PLATFORM_DRIVERS=y >> .config
    echo CONFIG_VIDEO_OMAP2_VOUT=[ym] >> .config
    yes "" | make oldconfig

both before and after applying this patch and diffing the "before" and
"after" .config. Only with this patch I see CONFIG_VIDEO_OMAP2_VOUT=[ym]
appear in the .config.

3) Actually, I've wasted quite a bit of time cobbling together a script
to test commits locally. The test(s) I want to run is (are) saved in a
git note for that commit. The script parses this note and runs the
test(s).

Have I been reinventing the wheel?

 drivers/media/platform/omap/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/omap/Kconfig b/drivers/media/platform/omap/Kconfig
index 05de442d24e4..8f27cdadf8b8 100644
--- a/drivers/media/platform/omap/Kconfig
+++ b/drivers/media/platform/omap/Kconfig
@@ -3,7 +3,8 @@ config VIDEO_OMAP2_VOUT_VRFB

 config VIDEO_OMAP2_VOUT
 	tristate "OMAP2/OMAP3 V4L2-Display driver"
-	depends on ARCH_OMAP2 || ARCH_OMAP3 || (COMPILE_TEST && HAS_MMU)
+	depends on MMU
+	depends on ARCH_OMAP2 || ARCH_OMAP3 || COMPILE_TEST
 	select VIDEOBUF_GEN
 	select VIDEOBUF_DMA_CONTIG
 	select OMAP2_DSS if HAS_IOMEM && ARCH_OMAP2PLUS
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/