linux-kernel - Re: [PATCH] gpu/drm/drm_sysfs.c: Export drm_sysfs_connector_add and drm_sysfs_connector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF6AEGsP2s2S=FecxoPP0V_f_eMXbFC-+Nui5cRotJLhC+YD9A@mail.gmail.com>
Date:	Mon, 24 Nov 2014 08:48:13 -0500
From:	Rob Clark <robdclark@...il.com>
To:	Mike Looijmans <mike.looijmans@...ic.nl>
Cc:	David Airlie <airlied@...ux.ie>,
	Lars-Peter Clausen <lars@...afoo.de>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpu/drm/drm_sysfs.c: Export drm_sysfs_connector_add and drm_sysfs_connector_remove

On Mon, Nov 24, 2014 at 7:25 AM, Mike Looijmans <mike.looijmans@...ic.nl> wrote:
> Building the adi_axi_hdmi driver as a module failed:
> ERROR: "drm_sysfs_connector_remove" [drivers/gpu/drm/adi_axi_hdmi/adi_axi_hdmi.ko] undefined!
>
> Mark drm_sysfs_connector_remove for export to fix this. Also mark
> drm_sysfs_connector_add for export, for symetry and because at least
> one other module uses it (xylon_connector.c).

no.. you should be using drm_connector_{register,unregister}() now,
and not calling the drm_sysfs_connector_{add,remove}() fxns directly..

BR,
-R

> Signed-off-by: Mike Looijmans <mike.looijmans@...ic.nl>
> ---
>  drivers/gpu/drm/drm_sysfs.c |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c
> index ab1a5f6..d0296cc 100644
> --- a/drivers/gpu/drm/drm_sysfs.c
> +++ b/drivers/gpu/drm/drm_sysfs.c
> @@ -438,6 +438,7 @@ err_out_files:
>  out:
>         return ret;
>  }
> +EXPORT_SYMBOL(drm_sysfs_connector_add);
>
>  /**
>   * drm_sysfs_connector_remove - remove an connector device from sysfs
> @@ -467,6 +468,7 @@ void drm_sysfs_connector_remove(struct drm_connector *connector)
>         device_unregister(connector->kdev);
>         connector->kdev = NULL;
>  }
> +EXPORT_SYMBOL(drm_sysfs_connector_remove);
>
>  /**
>   * drm_sysfs_hotplug_event - generate a DRM uevent
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/