linux-kernel - Re: FIX ME in xsysace.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <5e95919de4e349a6a7c5261cb1e9fda5@BN1BFFO11FD012.protection.gbl>
Date:	Mon, 24 Nov 2014 15:32:52 +0100
From:	Michal Simek <michal.simek@...inx.com>
To:	nick <xerofoify@...il.com>, Michal Simek <michal.simek@...inx.com>
CC:	<soren.brinkmann@...inx.com>, <grant.likely@...aro.org>,
	<robh+dt@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: Re: FIX ME in xsysace.c

Hi,

On 11/24/2014 12:28 PM, nick wrote:
> 
> 
> On 14-11-24 02:47 AM, Michal Simek wrote:
>> Hi,
>>
>> On 11/24/2014 05:19 AM, nick wrote:
>>> Greetings Michal and others,
>>> I am wondering about the FIX ME in xsysace.c as it seems not correct due to my knowledge of most hardware protocols using a predetermined bit wide and therefore this could be hard coded. If someone can respond on if I am correct in removing this fix me it would be greatly appreciated.
>>
>> I think that will be the best to c&p that fixme which you are talking about.
>> Definitely feel free to fix whatever fixme is there and send the patch
>> for fixing it.
>>
>> Thanks,
>> Michal
>>
> Here is the fix me.
> int bus_width = ACE_BUS_WIDTH_16; /* FIXME: should not be hard coded */

FIXME is totally bogus and should be removed.

I expect you want to use 8bit bus mode which driver itself supports.
This line is just default setup to 16bit mode.

If you add 8-bit property to dts you are there.
	if (of_find_property(dev->dev.of_node, "8-bit", NULL))
		bus_width = ACE_BUS_WIDTH_8;

Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/