linux-kernel - Re: [PATCH v1 2/3] usb: phy: Handle per-PHY event for connect and disconnect events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141124162143.GI20705@saruman>
Date:	Mon, 24 Nov 2014 10:21:43 -0600
From:	Felipe Balbi <balbi@...com>
To:	Sumit Semwal <sumit.semwal@...aro.org>
CC:	balbi <balbi@...com>, Kiran Raparthy <kiran.kumar@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>,
	John Stultz <john.stultz@...aro.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb <linux-usb@...r.kernel.org>,
	Android Kernel Team <kernel-team@...roid.com>,
	Arve Hj�nnev�g <arve@...roid.com>,
	Benoit Goby <benoit@...roid.com>,
	Todd Poynor <toddpoynor@...gle.com>
Subject: Re: [PATCH v1 2/3] usb: phy: Handle per-PHY event for connect and
 disconnect events

Hi,

On Mon, Nov 24, 2014 at 09:45:35PM +0530, Sumit Semwal wrote:
> On 24 November 2014 at 21:24, Felipe Balbi <balbi@...com> wrote:
> > On Mon, Nov 24, 2014 at 09:19:09PM +0530, Sumit Semwal wrote:
> >> Hi Felipe,
> >>
> >> On 24 November 2014 at 20:08, Felipe Balbi <balbi@...com> wrote:
> >> > Hi,
> >> >
> >> > On Fri, Nov 21, 2014 at 09:13:00PM +0530, Kiran Raparthy wrote:
> >> >> On 21 November 2014 20:41, Felipe Balbi <balbi@...com> wrote:
> >> >> > On Fri, Nov 21, 2014 at 11:31:21AM +0530, Kiran Raparthy wrote:
> >> >> >> usb: phy: Handle per-PHY event for connnect and disconnect events
> >> >> >>
> >> >> >> When usb is connected and enumerated in device mode or when usb is
> >> >> >> disconnected,call usb_phy_set_event from phy drivers to handle per-PHY event.
> >> >> >>
> >> >> >> Cc: Felipe Balbi <balbi@...com>
> >> >> >> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> >> >> >> Cc: linux-kernel@...r.kernel.org
> >> >> >> Cc: linux-usb@...r.kernel.org
> >> >> >> Cc: Android Kernel Team <kernel-team@...roid.com>
> >> >> >> Cc: John Stultz <john.stultz@...aro.org>
> >> >> >> Cc: Sumit Semwal <sumit.semwal@...aro.org>
> >> >> >> Cc: Arve Hj�nnev�g <arve@...roid.com>
> >> >> >> Cc: Benoit Goby <benoit@...roid.com>
> >> >> >> [Original patch in Android from Todd]
> >> >> >> Cc: Todd Poynor <toddpoynor@...gle.com>
> >> >> >> Signed-off-by: Kiran Raparthy <kiran.kumar@...aro.org>
> >> >> >
> >> >> > this patch doesn't apply, please rebase entire series on my testing/next.
> >> >
> >> > your rebased version didn't apply either. Can you make sure you're
> >> > rebasing on top of my today's testing/next branch ?
> >> >
> >> I just verified that I am able to apply both this patch (and the next
> >> one - so 2/3 and 3/3) on your testing/next branch - just to make sure,
> >> this is the git/branch right?
> >>
> >> https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
> >> branch:testing/next
> >
> > that's the correct branch, but here's what I get:
> 
> That's very odd - I pulled your branch for the first time about 5
> minutes before I sent the mail? perhaps local branch updates?


$ git show
commit c9d655dccea0cb6df20ba5b39294a24be045ea4f
Author: Fabio Estevam <fabio.estevam@...escale.com>
Date:   Wed Nov 19 12:37:53 2014 -0200

    usb: dwc2: Fix build warning when CONFIG_PM_SLEEP=n
    
    Building with bcm2835_defconfig, which has CONFIG_PM_SLEEP=n causes the
    following build warning:
    
    drivers/usb/dwc2/platform.c:227:12: warning: 'dwc2_suspend' defined but not used [-Wunused-function]
    drivers/usb/dwc2/platform.c:237:12: warning: 'dwc2_resume' defined but not used [-Wunused-function]
    
    Annotate these functions with '__maybe_unused' to prevent the warnings.
    
    Reported-by: Olof's autobuilder <build@...om.net>
    Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
    Signed-off-by: Felipe Balbi <balbi@...com>

diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
index ec5658a..6a795aa 100644
--- a/drivers/usb/dwc2/platform.c
+++ b/drivers/usb/dwc2/platform.c
@@ -226,7 +226,7 @@ static int dwc2_driver_probe(struct platform_device *dev)
 	return retval;
 }
 
-static int dwc2_suspend(struct device *dev)
+static int __maybe_unused dwc2_suspend(struct device *dev)
 {
 	struct dwc2_hsotg *dwc2 = dev_get_drvdata(dev);
 	int ret = 0;
@@ -236,7 +236,7 @@ static int dwc2_suspend(struct device *dev)
 	return ret;
 }
 
-static int dwc2_resume(struct device *dev)
+static int __maybe_unused dwc2_resume(struct device *dev)
 {
 	struct dwc2_hsotg *dwc2 = dev_get_drvdata(dev);
 	int ret = 0;

that's the head of my branch, which is testing/next. And I don't have
anything in my index:

$ git diff
$ echo $?
0


-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)