lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1416850383.4921.4.camel@dhcp-9-2-203-236.watson.ibm.com>
Date:	Mon, 24 Nov 2014 12:33:03 -0500
From:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
To:	David Howells <dhowells@...hat.com>
Cc:	mmarek@...e.cz, keyrings@...ux-nfs.org, d.kasatkin@...sung.com,
	rusty@...tcorp.com.au, linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org, vgoyal@...hat.com
Subject: Re: [Keyrings] [PATCH 2/5] X.509: Support X.509 lookup by
 Issuer+Serial form AuthorityKeyIdentifier

On Mon, 2014-11-24 at 16:58 +0000, David Howells wrote: 
> Mimi Zohar <zohar@...ux.vnet.ibm.com> wrote:
> 
> Mimi Zohar <zohar@...ux.vnet.ibm.com> wrote:
> 
> > +        if (id) {
> > +		lookup = id->data;
> > +		len = id->len;
> > +	}
> >  	if (!lookup) {
> 
> The last line here can then just be replaced by an else-clause.

I would assume so, but the original code looked like "id->data" could
have been null.

Mimi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ