linux-kernel - Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141124182053.GD25712@saruman>
Date:	Mon, 24 Nov 2014 12:20:53 -0600
From:	Felipe Balbi <balbi@...com>
To:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
CC:	<balbi@...com>, George Cherian <george.cherian@...com>,
	<gregkh@...uxfoundation.org>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is
 fully handled

On Mon, Nov 24, 2014 at 06:49:50PM +0100, Sebastian Andrzej Siewior wrote:
> On 11/18/2014 10:17 PM, Felipe Balbi wrote:
> > I think the driver is mis-detecting Babble. A babble only occurs when
> > the device side tries to move data without the host asking for anything.
> 
> It also occurs if the device moves more than packet_size bytes. Not
> really helping, I know…

hmm, why would the device move more than wMaxPacketSize at a time ?
That's certainly babble :-) We *must* move data in the wire in
<=wMaxPacketSize chunks.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)