linux-kernel - Re: [PATCH 2/3] wd719x: Introduce Western Digital WD7193/7197/7296 PCI SCSI card driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201411242134.43508.linux@rainbow-software.org>
Date:	Mon, 24 Nov 2014 21:34:43 +0100
From:	Ondrej Zary <linux@...nbow-software.org>
To:	Hannes Reinecke <hare@...e.de>
Cc:	linux-scsi@...r.kernel.org, Christoph Hellwig <hch@...radead.org>,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] wd719x: Introduce Western Digital WD7193/7197/7296 PCI SCSI card driver

On Monday 24 November 2014 14:15:47 Hannes Reinecke wrote:
> On 11/24/2014 01:11 PM, Ondrej Zary wrote:
> > Introduce wd719x, a driver for Western Digital WD7193, WD7197 and WD7296
> > PCI SCSI controllers based on WD33C296A chip.
> > Tested with WD7193 card.
> >
> > Reviewed-by: Christoph Hellwig <hch@....de>
> > Signed-off-by: Ondrej Zary <linux@...nbow-software.org>

[...]

> > +	result = wd719x_send_scb(scb);
> > +	if (result != DID_OK) {
> > +		dev_warn(&wd->pdev->dev, "can't queue SCB\n");
> > +		wd719x_finish_cmd(cmd, result);
> > +	}
> > +
> > +	spin_unlock_irqrestore(wd->sh->host_lock, flags);
> > +
> > +	return 0;
> > +}
>
> Why did you use 'wait_ready' here?
> Any sane HBA driver should set the queue depth parameters
> correctly to avoid this from happening.
> Wouldn't it be far better to just return HOST_BUSY here if
> the command register isn't free and submit the command
> directly otherwise?

It probably comes from the original driver. Will send a new version.

-- 
Ondrej Zary
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/