linux-kernel - Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54739B7C.7020102@linutronix.de>
Date:	Mon, 24 Nov 2014 21:56:28 +0100
From:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:	Felipe Balbi <balbi@...com>,
	George Cherian <george.cherian@...com>,
	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is
 fully handled

On 11/24/2014 09:39 PM, Peter Stuge wrote:
> Felipe Balbi wrote:
>>>> A babble only occurs when
>>>> the device side tries to move data without the host asking for anything.
>>>
>>> It also occurs if the device moves more than packet_size bytes. Not
>>> really helping, I know…
>>
>> hmm, why would the device move more than wMaxPacketSize at a time ?
> 
> Some devices are buggy.

for instance if the device comes out of resume and the clock is not yet
stable but the device sends data. That is not the case here, but an
example :)
I *think* for some reason the host did not really receive ep0
set_config request as planned. And device's answer is probably then
interpreted as data which is not expected (as Felipe said "device side
tries to move data without the host asking for anything").

>> That's certainly babble :-)
> 
> Certainly! But musb shouldn't fall over or lock up because of it, should it?

No and the patch fixes the issue. The strange thing is that it only
happens on the same device. Not if you connect host<->device with two
boards.

> //Peter
> 

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/