linux-kernel - Re: perf/branch-history branch build broken with NO_DEMANGLE=1 perf hists browser: Print overhead percent value for first-level callchain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141124212308.GE13167@kernel.org>
Date:	Mon, 24 Nov 2014 18:23:08 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Jiri Olsa <jolsa@...hat.com>, David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Brendan Gregg <brendan.d.gregg@...il.com>
Subject: Re: perf/branch-history branch build broken with NO_DEMANGLE=1 perf
 hists browser: Print overhead percent value for first-level callchain

Em Mon, Nov 24, 2014 at 12:48:41PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Mon, Nov 24, 2014 at 12:32:04PM -0300, Arnaldo Carvalho de Melo escreveu:
> > >        ^
> > > In file included from util/srcline.c:11:0:
> > > util/symbol.h:35:21: note: previous definition of ‘bfd_demangle’ was
> > > here
> > >  static inline char *bfd_demangle(void __maybe_unused *v,
> > >                      ^
> > > make[1]: *** [util/srcline.o] Error 1
> > > make: *** [util/srcline.o] Error 2
> > > make: Leaving directory `/home/git/linux/tools/perf'
> > > [acme@zoo linux]$ 
> > 
> > bisected it down to:
> 
> What I have is on the perf/branch-history branch, we can't both include
> bfd.h and symbol.h when NO_DEMANGLE=1, probably we should just move the
> stub inline to symbol-elf.c, its only user, but I have to check further,
> lunch time tho.

Fixed, pushed it out on my perf/core and perf/branch-history branches.

--branch-history stuff still on a separate branch because it explodes:

[root@zoo acme]# perf record -a -g -b sleep 2s
[ perf record: Woken up 7 times to write data ]
[ perf record: Captured and wrote 3.033 MB perf.data (~132504 samples) ]
[root@zoo acme]# perf report --stdio --branch-history
# To display the perf.data header info, please use --header/--header-only options.
#
BFD: Dwarf Error: Offset (2585882475) greater than or equal to .debug_str size (44321517).
BFD: Dwarf Error: Could not find abbrev number 11800.
<BIG SNIP>
BFD: Dwarf Error: Offset (83496016) greater than or equal to .debug_str size (44321517).
BFD: Dwarf Error: Offset (48628447) greater than or equal to .debug_str size (44321517).
(END)Segmentation fault (core dumped)
[root@zoo acme]# 

Will investigate this later today/tomorrow, if nobody finds a fix in the meantime.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/