lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Nov 2014 18:48:11 +0100 From: Cornelia Huck <cornelia.huck@...ibm.com> To: "Michael S. Tsirkin" <mst@...hat.com> Cc: linux-kernel@...r.kernel.org, David Miller <davem@...emloft.net>, rusty@....ibm.com, nab@...ux-iscsi.org, pbonzini@...hat.com, Rusty Russell <rusty@...tcorp.com.au>, virtualization@...ts.linux-foundation.org, linux-api@...r.kernel.org Subject: Re: [PATCH v4 09/42] virtio: set FEATURES_OK On Tue, 25 Nov 2014 18:42:01 +0200 "Michael S. Tsirkin" <mst@...hat.com> wrote: > set FEATURES_OK as per virtio 1.0 spec > > Signed-off-by: Michael S. Tsirkin <mst@...hat.com> > --- > include/uapi/linux/virtio_config.h | 2 ++ > drivers/virtio/virtio.c | 29 ++++++++++++++++++++++------- > 2 files changed, 24 insertions(+), 7 deletions(-) > > + if (virtio_has_feature(dev, VIRTIO_F_VERSION_1)) { > + add_status(dev, VIRTIO_CONFIG_S_FEATURES_OK); > + status = dev->config->get_status(dev); > + if (!(status & VIRTIO_CONFIG_S_FEATURES_OK)) { > + printk(KERN_ERR "virtio: device refuses features: %x\n", > + status); Can you use dev_err() to include the information which device failed? > + err = -ENODEV; > + goto err; > + } > + } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists