lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Nov 2014 17:54:29 +0000 From: Juri Lelli <juri.lelli@....com> To: Wanpeng Li <wanpeng.li@...ux.intel.com>, Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org> CC: Kirill Tkhai <ktkhai@...allels.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 2/2] sched/deadline: fix pull if dl task who's prio changed is not on queue Hi, On 19/11/14 08:35, Wanpeng Li wrote: > Dl task who is not on queue and it is also the curr task simultaneously > can not happen. In addition, pull since the priority of a not on queue > dl task doesn't make any sense. > > This patch fix it by don't pull if dl task who's prio changed is not on > queue. > > Signed-off-by: Wanpeng Li <wanpeng.li@...ux.intel.com> > --- > kernel/sched/deadline.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > index b9e44ae..4eaf55c 100644 > --- a/kernel/sched/deadline.c > +++ b/kernel/sched/deadline.c > @@ -1678,7 +1678,10 @@ static void switched_to_dl(struct rq *rq, struct task_struct *p) > static void prio_changed_dl(struct rq *rq, struct task_struct *p, > int oldprio) > { > - if (task_on_rq_queued(p) || rq->curr == p) { > + if (!task_on_rq_queued(p)) > + return; > + > + if (rq->curr == p) { Yeah. I already posted a patches for this, that I forgot to properly post again :/. I'll do it soon. Thanks, - Juri > #ifdef CONFIG_SMP > /* > * This might be too much, but unfortunately > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists