Message-ID: <5474E640.7020206@interlog.com>
Date:	Tue, 25 Nov 2014 15:27:44 -0500
From:	Douglas Gilbert <dgilbert@...erlog.com>
To:	"Akers, Jason B" <jason.b.akers@...el.com>,
	Phillip Susi <psusi@...ntu.com>,
	"linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>
CC:	"Karkra, Kapil" <kapil.karkra@...el.com>,
	"Williams, Dan J" <dan.j.williams@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] sg3_utils: Added hybrid information log utility

On 14-11-25 02:13 PM, Akers, Jason B wrote:
> Hi Phillip,
> It turns out that this patch was based on an old github repository that doesn't appear to be updated. Doug Gilbert reached out after the initial RFC and directed us to his page (http://sg.danny.cz/sg/) where he has updated sg3_utils code.
>
> As we continue to work through the feedback from our SSHD kernel patches, I'm going to follow up with Doug again on sg3_utils.

Hi,
As discussed earlier in this thread adding a new utility
for each log page like sg_sat_get_hybrid_log would lead to
hundreds of utilities. There are now these groups of
storage related pages (with user space utilities to decode
them shown in parentheses):
   - SCSI VPD pages  (sg_vpd (sdparm and legacy sg_inq))
   - SCSI mode pages (sdparm and sg_modes)
   - SCSI log pages  (sg_logs)
   - ATA GP log pages (from 1.40 sg_sat_read_gplog)
   - ATA SMART log pages (smartctl)

At the start of this thread the proposed patch was very
close to the release of sg3_utils version 1.40 and Hannes
Reinecke contributed a more general approach:
sg_sat_read_gplog which I did incorporate. Currently it
only decodes pages to hex.

Please look at that utility (i.e. sg_sat_read_gplog) as the
basis for adding ATA GP log page decoding such as the SATA
hybrid information page. Please send patches against its source.

Doug Gilbert


>> -----Original Message-----
>> From: Phillip Susi [mailto:psusi@...ntu.com]
>> Sent: Monday, November 24, 2014 4:34 PM
>> To: Akers, Jason B; linux-ide@...r.kernel.org
>> Cc: Karkra, Kapil; Williams, Dan J; linux-kernel@...r.kernel.org;
>> dgilbert@...erlog.com
>> Subject: Re: [RFC PATCH] sg3_utils: Added hybrid information log utility
>>
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA512
>>
>> On 10/29/2014 03:57 PM, Jason B. Akers wrote:
>>> From: Kapil Karkra <kapil.karkra@...el.com>
>>>
>>> A solid state hybrid drive (SSHD) is a hard drive with a small
>>> embedded NAND. Host drivers can manage this NAND using the
>> commands
>>> defined by SATA 3.2 standard. One SATA command that provides
>>> visibility into the SSHD's cache behavior is get hybrid log command.
>>> This augmentation allows users to issue the command as
>>> follows:
>>>
>>> sg_sat_get_hybrid_log /dev/sdc assuming /dev/sdc is an SSHD.
>>>
>>> patch applies to the following sourcebase from where to clone:
>>> https://github.com/hreinecke/sg3_utils.git
>>
>> I cloned that repo and the patch does not apply cleanly.  git am -3 says the
>> referenced blobs are not found and it has conflicts in src/Makefile.am.  I
>> manually fixed that up and then it fails to link due to unresolved externals.
>>
>>
>>
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v1
>>
>> iQEcBAEBCgAGBQJUc85UAAoJENRVrw2cjl5RR3YIAJOF0fcTkF5pM0OIA87hK8k
>> 8
>> ujwflBTy66ZbPzXMD97cTGYQ6gPp3UCeT/ZcElBfrGGAuD5u/ETXMJY7lqAZgYt
>> K
>> bELPv6oLhz3ya2IO442sUlRYO4dVfwhsnak+2rLiQkXCy4WKSJ1EYiMIP/VHj8ne
>> 5e8VYkuc0KamKjvT4v6EwJ7tM0blfJbYgmFGruIxOSgCAo94Zp9thAcctb9PbRex
>> HnPTcnw5cI1sCoLf5fJafhc9w/1H45WjJTnGF7zs4hq/GGsYCwryvI0ovwAzU9ST
>> R3jRvE+70oiyQDsj9EBak63hRYIAd8QzQ3TkCjaM5E1XHSU7vTnxvxAjKb4ZyF4=
>> =a8Vh
>> -----END PGP SIGNATURE-----

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists