linux-kernel - Re: [PATCH V4] arm64: amd-seattle: Adding device tree for AMD Seattle platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D09AF278.A61D%suravee.suthikulpanit@amd.com>
Date:	Tue, 25 Nov 2014 20:39:45 +0000
From:	"Suthikulpanit, Suravee" <Suravee.Suthikulpanit@....com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	"mark.rutland@....com" <mark.rutland@....com>,
	"will.deacon@....com" <will.deacon@....com>,
	"marc.zyngier@....com" <marc.zyngier@....com>,
	"catalin.marinas@....com" <catalin.marinas@....com>,
	"robherring2@...il.com" <robherring2@...il.com>,
	"liviu.dudau@....com" <liviu.dudau@....com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"arm@...nel.org" <arm@...nel.org>,
	"Lendacky, Thomas" <Thomas.Lendacky@....com>,
	"Schopp, Joel" <Joel.Schopp@....com>
Subject: Re: [PATCH V4] arm64: amd-seattle: Adding device tree for AMD
 Seattle platform



On 11/25/14, 18:57, "Arnd Bergmann" <arnd@...db.de> wrote:

>On Monday 24 November 2014 15:51:17 suravee.suthikulpanit@....com wrote:
>> 
>> +	gic: interrupt-controller@...01000 {
>> +		compatible = "arm,gic-400", "arm,cortex-a15-gic";
>> +		interrupt-controller;
>> +		#interrupt-cells = <3>;
>> +		#address-cells = <2>;
>> +		#size-cells = <2>;
>> +		reg = <0x0 0xe1110000 0 0x1000>,
>> +		      <0x0 0xe112f000 0 0x2000>,
>> +		      <0x0 0xe1140000 0 0x10000>,
>> +		      <0x0 0xe1160000 0 0x10000>;
>> +		interrupts = <1 9 0xf04>;
>> +		ranges;
>> +		v2m0: v2m@...80000 {
>> +			compatible = "arm,gic-v2m-frame";
>> +			msi-controller;
>> +			arm,msi-base-spi = <64>;
>> +			arm,msi-num-spis = <256>;
>> +			reg = <0x0 0xe1180000 0 0x1000>;
>> +		};
>> +	};
>
>
>Having an empty ranges property in the gic seems strange, especially
>since the registers of the v2m seem to directly follow the gic's own
>registers. Could you limit the ranges to only the registers that
>are in the gic or its child devices itself?
>
>	Arnd

Yes, I can change it to ranges = <0 0 0 0xe1100000 0 0x100000> to limit
the range to just the GIC address range.

Thanks,

Suravee

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/