linux-kernel - Re: [PATCH v2 2/8] irqchip: Supply new driver for STi based devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2433040.4NqTrOMmEE@wuerfel>
Date:	Tue, 25 Nov 2014 21:57:07 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, tglx@...utronix.de, kernel@...inux.com,
	jason@...edaemon.net
Subject: Re: [PATCH v2 2/8] irqchip: Supply new driver for STi based devices

On Tuesday 25 November 2014 16:24:59 Lee Jones wrote:

> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index b21f12f..e502f15 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -93,6 +93,13 @@ config RENESAS_IRQC
>  	bool
>  	select IRQ_DOMAIN
>  
> +config ST_IRQCHIP
> +	bool
> +	select REGMAP
> +	select MFD_SYSCON
> +	help
> +	  Enables SysCfg Controlled IRQs on STi based platforms.
> +

I'm confused by the purpose of this code. It's apparently a driver
in drivers/irqchip, the Kconfig symbol contains the string IRQCHIP,
yet it doesn't actually register an irq_chip.

Also, the name is a bit too generic, ST has lots of different irqchips,
and this apparently isn't even one of them ;-)

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/