[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20141125210222.GO7712@sirena.org.uk>
Date: Tue, 25 Nov 2014 21:02:22 +0000
From: Mark Brown <broonie@...nel.org>
To: Olof Johansson <olof@...om.net>
Cc: Weike Chen <alvin.chen@...el.com>,
Eric Miao <eric.y.miao@...il.com>,
Russell King <linux@....linux.org.uk>,
Haojian Zhuang <haojian.zhuang@...il.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, linux-spi@...r.kernel.org,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Mika Westerberg <mika.westerberg@...el.com>,
Hock Leong Kweh <hock.leong.kweh@...el.com>,
Boon Leong Ong <boon.leong.ong@...el.com>,
Raymond Tan <raymond.tan@...el.com>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH 2/2 v2] SPI: spi-pxa2xx: SPI support for Intel Quark X1000
On Tue, Nov 25, 2014 at 12:06:41PM -0800, Olof Johansson wrote:
> On Mon, Sep 29, 2014 at 7:22 AM, Weike Chen <alvin.chen@...el.com> wrote:
> > This piece of work is derived from Dan O'Donovan's initial work for Intel Quark
> > X1000 SPI enabling.
> How about build testing for other platforms that share this driver
> when you make changes to it? This is obviously completely broken.
> Doing these constants under ifdef seems fragile at best, braindead at
> worst. Please don't proliferate that coding style.
> Mark, can you revert until Intel learns how to play well with others?
Yeah.
> This is from a pxa3xx-defconfig build:
Ugh, why does this driver not have a COMPILE_TEST dependency? Not that
it'd have caught this one.
Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)
Powered by blists - more mailing lists