linux-kernel - Re: [PATCH V5 3/3] perf tool: check buildid for symoff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141125115159.GE30861@krava.brq.redhat.com>
Date:	Tue, 25 Nov 2014 12:51:59 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Kan Liang <kan.liang@...el.com>
Cc:	acme@...nel.org, namhyung@...nel.org, linux-kernel@...r.kernel.org,
	ak@...ux.intel.com
Subject: Re: [PATCH V5 3/3] perf tool: check buildid for symoff

On Mon, Nov 24, 2014 at 11:00:29AM -0500, Kan Liang wrote:
> From: Kan Liang <kan.liang@...el.com>
> 
> symoff can support both same binaries and different binaries. However,
> the offset may be changed for different binaries. This patch checks the
> buildid of perf.data. If they are from different binaries, print a
> warning to notify the user.
> 
> Signed-off-by: Kan Liang <kan.liang@...el.com>
> ---
>  tools/perf/builtin-diff.c | 25 +++++++++++++++++++++++++
>  tools/perf/util/sort.c    |  3 +++
>  tools/perf/util/sort.h    |  1 +
>  3 files changed, 29 insertions(+)
> 
> diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
> index 03a4001..2a8c17a 100644
> --- a/tools/perf/builtin-diff.c
> +++ b/tools/perf/builtin-diff.c
> @@ -678,6 +678,28 @@ static void data__free(struct data__file *d)
>  	}
>  }
>  
> +static void buildid_check(void)
> +{
> +	struct dsos *base_k_dsos = &data__files[0].session->machines.host.kernel_dsos;
> +	struct dsos *base_u_dsos = &data__files[0].session->machines.host.user_dsos;
> +	struct dsos *k_dsos_tmp, *u_dsos_tmp;
> +	struct data__file *d;
> +	int i;
> +
> +	data__for_each_file_new(i, d) {
> +		k_dsos_tmp = &d->session->machines.host.kernel_dsos;
> +		u_dsos_tmp = &d->session->machines.host.user_dsos;
> +
> +		if (!dsos__build_ids_equal(base_k_dsos, k_dsos_tmp))
> +			pr_warning("The perf.data come from different kernel. "
> +				   "The kernel symbol offset may vary for different kernel.\n");
> +
> +		if (!dsos__build_ids_equal(base_u_dsos, u_dsos_tmp))
> +			pr_warning("The perf.data come from different user binary. "
> +				   "The user space symbol offset may vary for different binaries.\n");

we dont specify the kernel version or dso path in the warning message,
maybe we want to print it out just once? In case there's more than 2
not matching data?

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/